Fix --hostname switch - #4
Merged
Merged
Conversation
This fixes a long-standing bug where using "--hostname x" (as opposed to "--hostname=x" resulted in duplication hostname switches being passed to the tailscale binary. Historically this bug has been masked by the fact that tailscale ignored all but the last of these, and the user-specified (non-default) one coincidentally got placed last. However, tailscale has recently started barfing on the duplicate switch so you could no longer use --hostname in the non-= form even though that's the form recommended in the documentation.
Owner
|
Sorry a bit behind on this stuff. This looks great, thank you. I'll get it merged and a new release cut this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing bug where using "--hostname x" (as opposed to "--hostname=x" resulted in duplication hostname switches being passed to the tailscale binary. Historically this bug has been masked by the fact that tailscale ignored all but the last of these, and the user-specified (non-default) one coincidentally got placed last. However, tailscale has recently started barfing on the duplicate switch so you could no longer use --hostname in the non-= form even though that's the form recommended in the documentation.